facebook / mysql-5.6

Facebook's branch of the Oracle MySQL database. This includes MyRocks.

Home Page:http://myrocks.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Consider updating rocksdb/Makefile

mdcallag opened this issue · comments

rocksdb/Makefile is hardwired to use -march=armv8+a+crc+crypto. That won't take advantage of features on modern ARM. A workaround is to use -march=native (works on gcc, not supported on ARM), -mcpu=native (should work on both). Alas, these options can limit portability of the resulting binary. Other possible values are here.

I encountered this while trying to explain perf differences for xxh3 between x86 and ARM. See here. But changing CXXFLAGS didn't fix that problem.