Wrong `DCMAKE_TOOLCHAIN_FILE` in docs
changwoolab opened this issue · comments
Description
docs link: https://hermesengine.dev/docs/emscripten/#setting-up-workspace-and-host-hermesc
I think DCMAKE_TOOLCHAIN_FILE should be
-DCMAKE_TOOLCHAIN_FILE=${EmscriptenRoot?}/cmake/Modules/Platform/Emscripten.cmake
Because docs says
$EmscriptenRoot = ~/emsdk/upstream/emscripten and
-DCMAKE_TOOLCHAIN_FILE=${EmscriptenRoot?}/emscripten/cmake/Modules/Platform/Emscripten.cmake
but there is no ~/emsdk/upstream/emscripten/emscripten/cmake/* but ~/emsdk/upstream/emscripten/cmake/*
I'm a noob to this and I could be wrong.
Thank you!
Good catch, we'll fix our documentation. Note that the website hasn't been updated in some time, and our most up-to-date documentation can be found in the doc directory of the repo.
@changwoolab, also, this part of the documentation is intended as a rough guide for compiling Hermes with emscripten. It isn't necessarily kept up to date with the latest versions of emscripten and Hermes, so you may run into some rough edges.
Some other references that may be useful as you try building Hermes this way are our CI config (which builds Herms with Emscripten), and our more recent instructions for building the Hermes sandbox.
Oh Thank you!