facebook / duckling

Language, engine, and tooling for expressing, testing, and evaluating composable language rules on input strings.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Up Text and Hashable constraints

L0neGamer opened this issue · comments

In #724 I bump aeson and make it work across versions.

It would be good if duckling can update the constraints on Text and Hashable so it works on a modern version of GHC.

for hashable, one merely needs to add the following to Duckling.Types:

-- Eq
instance Eq (Dimension a) where
  (==) a b = hash a == hash b

For Text there are more detailed changes needed, as Text switches from UTF-16 to UTF-8, and Duckling uses internals functions to manipulate Texts.

Suggested new bounds are hashable >= 1.2.4.0 && < 1.5 and text >= 2 && < 2.2