facebook / duckling

Language, engine, and tooling for expressing, testing, and evaluating composable language rules on input strings.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Time.TR] Forgot to add to test suite?

emlautarom1 opened this issue · comments

Turkish corpus is not used at all, resulting in an empty classifier:

classifiers = HashMap.fromList []

The cause is that the test suite ("corpus") is never used (the module Duckling.Time.TR.Tests is not even imported):

tests :: TestTree
tests = testGroup "Time Tests"
[ AR.tests
, BG.tests
, CA.tests
, DA.tests
, DE.tests
, EL.tests
, EN.tests
, ES.tests
, FR.tests
, GA.tests
, HR.tests
, HE.tests
, HU.tests
, IT.tests
, KA.tests
, KO.tests
, NB.tests
, NL.tests
, PL.tests
, PT.tests
, RO.tests
, RU.tests
, SV.tests
, UK.tests
, VI.tests
, ZH.tests
, timeFormatTest
, timeIntersectTest
]

Said module is also not declared in the duckling.cabal file:

duckling/duckling.cabal

Lines 1136 to 1163 in 84175d6

-- Time
, Duckling.Time.AR.Tests
, Duckling.Time.BG.Tests
, Duckling.Time.CA.Tests
, Duckling.Time.DA.Tests
, Duckling.Time.DE.Tests
, Duckling.Time.EL.Tests
, Duckling.Time.EN.Tests
, Duckling.Time.ES.Tests
, Duckling.Time.FR.Tests
, Duckling.Time.GA.Tests
, Duckling.Time.HR.Tests
, Duckling.Time.HE.Tests
, Duckling.Time.HU.Tests
, Duckling.Time.IT.Tests
, Duckling.Time.KA.Tests
, Duckling.Time.KO.Tests
, Duckling.Time.NB.Tests
, Duckling.Time.NL.Tests
, Duckling.Time.PL.Tests
, Duckling.Time.PT.Tests
, Duckling.Time.RO.Tests
, Duckling.Time.RU.Tests
, Duckling.Time.SV.Tests
, Duckling.Time.UK.Tests
, Duckling.Time.VI.Tests
, Duckling.Time.ZH.Tests
, Duckling.Time.Tests

This is a trivial fix. There are some failing test cases though!

Would you like to prepare a PR for this?