facebook / akd

An implementation of an auditable key directory

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Simplifying code

Jasleen1 opened this issue · comments

The code in history_tree_node.rs and append_only_zks.rs can be further simplified. A few suggestions:

  • Remove any remaining instances of unwrap().
  • Look for repeated code among conditionals and abstract it out into a separate function.

I believe this is almost done, except that we also need to get rid of all sources of panic, such as assert

I believe this is almost done, except that we also need to get rid of all sources of panic, such as assert

I looked for assert statements and it seems now we only have asserts in test cases. We could likely close this issue.