facebook / OpenBIC

BICs (Bridge IC) are standalone devices deployed within a Data Center that enable monitoring a multi-host system using a single BMC device.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Some declarations of common sensor functions are not matched to their corresponding definitions.

Scron-Chang opened this issue · comments

Hi @DelphineChiu

I got some error messages from the Build and Analyze: run-cppcheck task.

Files to check:
common/service/sensor/sensor.c
Errors Found:
common/service/sensor/sensor.c:274:26:Function 'stby_access' argument 1 names different: declaration 'sensor_num' definition 'sensor_number'.
common/service/sensor/sensor.c:279:24:Function 'dc_access' argument 1 names different: declaration 'sensor_num' definition 'sensor_number'.
common/service/sensor/sensor.c:284:26:Function 'post_access' argument 1 names different: declaration 'sensor_num' definition 'sensor_number'.
common/service/sensor/sensor.c:289:24:Function 'me_access' argument 1 names different: declaration 'sensor_num' definition 'sensor_number'.

The root cause should be some declarations don't match their corresponding definition.
For instance,

bool stby_access(uint8_t sensor_number)
{
return true;
}

bool stby_access(uint8_t sensor_num);

What would you suggest to handle this issue?