facebook / OpenBIC

BICs (Bridge IC) are standalone devices deployed within a Data Center that enable monitoring a multi-host system using a single BMC device.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Modify code for sensor reading

Yi-Shum opened this issue · comments

Hi @DelphineChiu,

We want to modify the code for sensor reading, including:

  1. The member init_args in struct sensor_cfg should only be used in the function DeviceName_init().
    So we want to add a private data member that will be used in other functions such as DeviceName_read().
  2. Add the header files for each sensor.
  3. Changed ADC amplification calculation from arg0 and arg1 to post_sensor_read_hook and post_sensor_read_args.

Do you have any suggestions for this?

Thanks,
Yi-Shum

Hi @Yi-Shum

Meta and we plan to have main_v2 ready on 3/31.
Would you pls check main_v2 on #189 and provide the optimization based on main_v2?

cc @GoldenBug

Thanks,
Delphine