Expand the functionality for private github domains

[SDSethia]

Provide plugin options to expand the functionality for private github domains
eg: github.some_company.com

[Robert Redburn]

@fabiocchetti perhaps just a simple change like this is sufficient for everyone (?)

"matches": ["*://github*.com/*"],

(forked and tested this change works fine on github.ibm.com)

[Daniel Castro]

"matches": ["://github.com/*"],

This wouldn't work in my case actually... It would have to be something like:

"matches": ["*://*github*.com/*"],

[Fabio Biocchetti]

Thanks for your suggestions.

It should be fixed on version 1.1.0.

Since I don't have access to any private GitHub domain, I've been unable to test it. Please file a new issue if it's still not working as expected.

[Federico Brigante]

@fabiocchetti that won't work because the extension doesn't have permission to access those domains. You'd need optional_permissions, a way to request permissions by the user, and a way to dynamically inject the scripts.

I wrote two modules to help you with that, the implementation is rather simple, it just needs 3 lines of code and some adjustments to manifest.json

[Fabio Biocchetti]

Hello @fregante, thanks for sharing this. It's really interesting and I'll look into it in the future.