Giters

fabiocaccamo / FCUUID

:iphone: :id: iOS UUID / Universally Unique Identifiers library as alternative to UDID and identifierForVendor.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Carthage support ?

Vinzius opened this issue · comments

commented

Hi Team,

First, thanks for the work!

Would you consider an update if I do a PR with Carthage support?

Cheers,
Vincent

commented

Thanks!
Any improvement is appreciated :)

commented

Ok, I'll try to submit one soon :-)
Thanks for the fast reply.

Edit: I think Carthage is iOS8+. So maybe it'll be on another Branch if you plan to keep iOS5+ (which is very likely).

commented

Frankly, I never used Carthage and I'm not working on iOS right now.
I would not create another branch, instead I would just specify in the documentation that with iOS8+ it possible to install the lib using cartage, is it possible?

commented

In order to use Carthage, you need to have schemes (so an xcodeproj) (details here).

For the iOS8 requirement, it's because of the dynamic frameworks.

I understand you don't really want to complicate the architecture of this library. Thus I'll probably just do a manual installation or fork the project (I stop using Cocoapods).

That being said, I'm not sure what is required to support swift package manager, but I think it would be a nice addition to the project.

commented

Yes, I don't want to complicate the architecture of this library and from my point of view I prefer centralized package managers. By the way this is just my opinion and many users prefer to use Carthage.

If we add the xcodeproj, the Objective-C sources should be moved inside it or they can rest were they are and Cocoapods will continue to works?

This library would need to be ported to swift too.
I will add support to swift package manager.