fabian-hiller / valibot

The modular and type safe schema library for validating structural data 🤖

Home Page:https://valibot.dev

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[docs] Command + K doesn't prevent default, opening the URL bar in Firefox

CapitaineToinon opened this issue · comments

In Firefox, doing Command + K will focus the URL bar to search things on Google. When using that same shortcut for site-wise search, the event needs to be prevent defaulted to avoid passing on the event to Firefox.

image

In a traditional JS framework such as React or Vue, this would be an easy fix but by the nature of the Qwik framework, I'm not exactly sure how to fix this myself for a PR.

Apparently we could take a look at the $sync helper to synchronously prevent default. That feature is currently in beta though but I'll look into it.

https://qwik.dev/docs/cookbook/sync-events/#sync-synchronous-events-beta

Thank you for creating this issue! It is related to #432.