Put ghstack message below commit message body / update local message with remote
thorbenprimke opened this issue · comments
Just another observation from using it - enjoying ghstack more every day. :)
I was wondering if there is a (technical) reason that the ghstack info is inserted above the commit message? Maybe it could be a config to either inject the stack info above or below the message.
And I was curious if amending the local commit message with remote changes has come up in the past? The use case here is that I/we often add screenshots to a commit on github.com directly. When I update the commit by running ghstack again, the remote edits are overwritten.
That's all - one of these days I have to take an afternoon to work on these improvements. ;)
I was wondering if there is a (technical) reason that the ghstack info is inserted above the commit message?
There is no technical reason. An aesthetic reason for placing it up top is when you navigate between PRs, the stack list stays at a fixed position (like a menubar). If you want to add a config to toggle it, I guess it's OK; it doesn't seem like the payoff is that great though, but it's pretty simple.
And I was curious if amending the local commit message with remote changes has come up in the past? The use case here is that I/we often add screenshots to a commit on github.com directly. When I update the commit by running ghstack again, the remote edits are overwritten.
Ah yes, this should exist as a feature, it just hasn't been written. Please implement it as ghstack sync [--stack]
(stack argument to update all commits in your stack).
Duping it as #67