ezyang / ghstack

Submit stacked diffs to GitHub on the command line

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Failures in GH Action jobs are not obvious

felix-seifert opened this issue · comments

As already experienced in #176, test failures do not let the GH Actions job fail. This job on Windows, for example, shows test failures in the Run tests step. However, the job is still green. To discover these test failures, you would have to scan every job for each workflow run.

DoD: Failures of the test suite should make a GH Actions job fail/be red.

The problem was you were suppressing the exit code of the child processes. I went ahead and fixed it.