Some small fixes/improvements
michelkaeser opened this issue · comments
https://github.com/eyecatchup/SEOstats/blob/master/SEOstats/Services/Alexa.php#L187 should include a !== null check as $node2 sometimes is null.
https://github.com/eyecatchup/SEOstats/blob/master/SEOstats/Services/3rdparty/GTB_PageRank.php and https://github.com/eyecatchup/SEOstats/blob/master/SEOstats/Helper/HttpRequest.php uses curl_exec which might fail in case of http://stackoverflow.com/questions/10835255/curlopt-followlocation-cannot-be-activated-when-safe-mode-is-enabled-or-an-open
Using the function from the answer solves that.
at topic alexa: #93 will merge in the next week
at topic curl: yes following request are on the wanted feature list, but current we have enough work in progress. This feature will be come in the case we change to a HttpClient library.
thanks for you feedback
Adding a small bug:
Sistrix code comments imply returning of integer values, however they are strings (doubles comma-separated instead of decimal points).
"* @return integer Returns the Sistrix visibility index."