eyalroz / tpch-dbgen

Data & query generation utilities for the TPC-H benchmark (unified repository)

Home Page:http://www.tpc.org/tpch/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Avoid the need for the user to specify MACHINE

eyalroz opened this issue · comments

CMake should be able to provide sufficient information regarding the platform on which we're building so as to obviate the need for setting the MACHINE parameter. Right now,

At the moment, the effects of MACHINE are:

  1. Choosing between sets of preprocessor defines in config.h:
#define _INCLUDE_POSIX_SOURCE /* or not define it */
#define STDLIB_HAS_GETOPT /* or not define it */
#define SUPPORT_64BITS /* or not define it */
#define DSS_HUGE long
#define HUGE_COUNT 2
#define HUGE_FORMAT "%ld"
#define HUGE_DATE_FORMAT "%02lld"
#define RNG_C 1ull
#define RNG_A 6364136223846793005ul
  1. Some code in config.hand driver.ci is conditioned ondefined(POSIX)||!defined(WIN32))- mostly relating to working with process id's and signals, and related#include`s.
  2. Path separator definition
  3. Use of an MS Visual Studio intrinsic instead of strdup() - for some really old version of MSVC

Also, it seems WIN32 is linked to the use of DATABASE=SQLSERVER for some reason

  1. Some WIN32-specific optimizations under WIN32_Lean-and-Mean

... have I missed something?