eyalroz / ssb-dbgen

Star Schema Benchmark data set generator (dbgen) - unified repository

Home Page:http://www.cs.umb.edu/~poneil/StarSchemaB.PDF

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Windows+MinGW build fails: "sys/wait.h: No such file or directory"

eyalroz opened this issue · comments

Building our current additional_fixes branch head (commit bac88be) fails with Windows, MinGW and GCC 8.1.0. Build log snippet:

Done. Your build exited with 1.
C:\Users\travis\build\eyalroz\ssb-dbgen\src\driver.c:13:10: fatal error: sys/wait.h: No such file or directory
 #include <sys/wait.h>
          ^~~~~~~~~~~~
compilation terminated.

So:

  • How should we tweak the condition for inclusion?
  • When we stop including this header - will the build complete, or do we need to replace some wait()/waitpid() calls?

@valco1994 , could you look into this?

sys/wait.h is necessary for parallel data generation. In PR #58 I check its presence in CMakeLists.txt, wrap its inclusion into corresponding #ifdefand consider it as a piece of criteria for allowing parallel data generation.

Yeah, this should be solved by #PR 58. Note that this will be the last error for the MinGW build, so once you've tweaked #PR 58 a bit more, we should probably have both Windows builds working :-)

This issue was fixed in PR #64