Incompatible pointer types in Windows+MinGW build
eyalroz opened this issue · comments
Eyal Rozenberg commented
When building with Windows+MinGW (with GCC 8.1.0), we get, among others, the following kind of warning:
C:\Users\travis\build\eyalroz\ssb-dbgen\src\build.c: In function 'hd_sparse':
C:\Users\travis\build\eyalroz\ssb-dbgen\src\build.c:192:14: warning: passing argument 2 of 'bin_bcd2' from incompatible pointer type [-Wincompatible-pointer-types]
bin_bcd2(i, base, base + 1);
^~~~
In file included from C:\Users\travis\build\eyalroz\ssb-dbgen\src\build.c:24:
C:\Users\travis\build\eyalroz\ssb-dbgen\src\bcd2.h:4:33: note: expected 'long int *' but argument is of type 'long long int *'
int bin_bcd2(long binary, long *low_res, long *high_res);
~~~~~~^~~~~~~
This takes me back to one of the earliest fixes I checked in, though I forget which one; we use to have this type mismatch on other platforms as well.
Eyal Rozenberg commented
I suspect this should be resolved by using DSS_HUGE
more pervasively. Let's try that.