expressjs / express

Fast, unopinionated, minimalist web framework for node.

Home Page:https://expressjs.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

The `max sync stack` is breaking routing

minghaopu63 opened this issue · comments

We recently updated to v4.18.0 and find some routes are not working anymore due to 708ac4c.

  1. This 100 limitation is not in the change log http://expressjs.com/en/changelog/4x.html#4.18.0. Can you help update it?
  2. Can this value be configurable?

Thanks

Hi @minghaopu63 the limit is not a max number of routes or anything. You can still have an infinite about. Can you provide a reproduction case the demonstrates what broke? The change should be transparent, so the fix would make it work the same as before.

Hi @dougwilson, here is a repo i just set up to reproduce the issue. https://github.com/minghaopu63/express-test.

After clone, you can run the following steps to reproduce this.

  1. npm i
  2. npm run build
  3. npm start
  4. visit http://localhost:3000/abcd

Thank you, this was very helpful! I see what the issue is. I will have a 4.18.1 out ASAP with the fix. You are awesome!!!

Ok, fix published as version 4.18.1 🎉

Thanks!