express-labs / pure-react-carousel

A highly impartial suite of React components that can be assembled by the consumer to create a carousel with almost no limits on DOM structure or CSS styles. If you're tired of fighting some other developer's CSS and DOM structure, this carousel is for you.

Home Page:https://express-labs.github.io/pure-react-carousel/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Slider OnClick is not being prevented on Carousel movement

Conor-Hinchee opened this issue · comments

  • pure-react-carousel version: 1.27.6
  • react version: 17.0.2
  • node version: v10.16.1

Relevant code or config:

<Slider> > handleOnClickCapture(ev) line #286
Screen Shot 2021-08-05 at 1 10 43 PM

const your = code => 'here';

What you did:

We are attempting to prevent clicks of the carousel slider when the carousel is in movement.

What happened:

The onClick event is still triggered on drag events

Reproduction:

Suggested solution:

Remove the line #293 from <Slider /> =

Can you help us fix this issue by submitting a pull request?

commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Any update on this? :)

This is really painful, and combined with how there is no onDrag event callbacks, I can't find a way to ignore the click after a drag.

commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

commented

This issue has been automatically closed becuase it has not had recent activity.

Hey this is not stale.