expo / google-fonts

Use any of the 1000+ fonts (and their variants) from fonts.google.com in your Expo app.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

expo google fonts types say `__metdata__` but the actual object uses `__metadata__`

trajano opened this issue · comments

Summary

If you look at the typings for Google fonts loaded using Expo, it has __metdata__ but it should be __metadata__. It's just a one character typo, but needs the fonts to be all regenerated.

Managed or bare workflow? If you have ios/ or android/ directories in your project, the answer is bare!

managed

What platform(s) does this occur on?

Android, iOS, Web

SDK Version (managed workflow only)

42

Environment

Expo CLI 4.11.0 environment info:
System:
OS: macOS 11.5.2
Shell: 5.8 - /bin/zsh
Binaries:
Node: 12.18.0 - ~/.nvm/versions/node/v12.18.0/bin/node
Yarn: 1.22.11 - ~/.nvm/versions/node/v12.18.0/bin/yarn
npm: 6.14.11 - ~/.nvm/versions/node/v12.18.0/bin/npm
Watchman: 2021.08.30.00 - /usr/local/bin/watchman
Managers:
CocoaPods: 1.10.1 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: iOS 14.5, DriverKit 20.4, macOS 11.3, tvOS 14.5, watchOS 7.4
IDEs:
Android Studio: 4.1 AI-201.8743.12.41.6858069
Xcode: 12.5.1/12E507 - /usr/bin/xcodebuild
npmPackages:
expo: ~42.0.1 => 42.0.3
react: 16.13.1 => 16.13.1
react-dom: 16.13.1 => 16.13.1
react-native: https://github.com/expo/react-native/archive/sdk-42.0.0.tar.gz => 0.63.2
react-native-web: ~0.13.12 => 0.13.18
npmGlobalPackages:
expo-cli: 4.11.0
Expo Workflow: managed

Reproducible demo or steps to reproduce from a blank project

npm install @expo-google-fonts/libre-baskerville

Then look at the typings file.

Hi @trajano, thanks for mentioning this! We will patch it asap!

Thanks! Just fixed this. Next time we do a release the types will be update.

@ccheever as in Expo 43?

No, next time this package is released. That is independent of the Expo SDK release cycle.
I'll try to do one soon but it takes me a few hours because all the packages have to be regenerated and published to npm, etc. and there are over 1000 of them.

I guess this would be a job for Github actions so you don't have to do it manually.