exif-js / exif-js

JavaScript library for reading EXIF image metadata

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

fix unexpected global varible in loop

xiangnanscu opened this issue Β· comments

Hi! πŸ‘‹

Firstly, thanks for your work on this project! πŸ™‚

Today I used patch-package to patch exif-js@2.3.0 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/exif-js/exif.js b/node_modules/exif-js/exif.js
index 35395cf..1984373 100644
--- a/node_modules/exif-js/exif.js
+++ b/node_modules/exif-js/exif.js
@@ -738,7 +738,7 @@
 
     function getStringFromDB(buffer, start, length) {
         var outstr = "";
-        for (n = start; n < start+length; n++) {
+        for (var n = start; n < start+length; n++) {
             outstr += String.fromCharCode(buffer.getUint8(n));
         }
         return outstr;

This issue body was partially generated by patch-package.