exhibitionist-digital / ultra

Zero-Legacy Deno/React Suspense SSR Framework

Home Page:https://ultrajs.dev

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

The `ignored` option is not working

rojvv opened this issue · comments

commented

No file or directory can be ignored when building.

Hey @roj1512 thanks for reporting, could you please add a reproduction of your build config?

In the new release 2.1.5 if your ignore pattern ends with a / it now assumes that you want to deeply ignore anything matching that pattern!

So doing the below (for instance) would now work

builder.ignore('./.git/')

Thanks, and sorry for not being so active.

I’ve just upgraded to 2.1.5.

  • The .git directory is now ignored, but it still copies some unwanted files.

Here’s my config:

image

And here is the unexpected result:

image

Wait, the .git is also not ignored. It ignores it only like you said, ./.git/. Which is kinda weird, isn’t it?

It needs to end with a slash unfortunately, just because of how https://deno.land/std@0.167.0/path/glob.ts?s=globToRegExp works

@deckchairlabs are you still with me here?

I want to ignore single files

#221 (comment)

Hi @roj1512 yes still here! Just haven't had the time to look into a solution for this. Could you open a separate issue for ignoring single files? Thanks!

That’s pretty fine, take your time! Sure, I’m doing it right now.

In the meantime it looks like if you make the "patterns" relative it works okay in my testing eg.

ignored: [
  "./.gitignore"
]