Salt Initializer
Kentasmic opened this issue Β· comments
Kentastic commented
I think the text in the initializer and documentation should be :
PrefixedIds.salt = "usersalt"
instead of what is in the documentation:
PrefixID.salt = "usersalt"
Chris Oliver commented
Want to send a PR to fix it?
Kentastic commented
Sure! But first I will need to figure out how to do that. π€π
I will try to do that tonight.
Kent
On October 26, 2022, "dependabot[bot]" ***@***.***> wrote:
Want to send a PR to fix it?
β
Reply to this email directly, view it on GitHub
<#32 (comment)-
1291486974>, or unsubscribe
<https://github.com/notifications/unsubscribe-
auth/AQPMWL56HG5EWGJ6KCMVYG3WFCYBJANCNFSM6AAAAAAROQTZGU>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
Chris Oliver commented
You can do it on GitHub by clicking edit on the README. That way you don't have to fork and create a PR unless you want to. π
Kentastic commented
Done! (edited readme)
Chris Oliver commented
Fixed by #33 (I created the PR for you)
Kentastic commented
Thanks! A GoRails video on how to do super simple pull requests would be
a great video! I saw the request.js one but that is more involved, I
mean more for typos in the readme or very simple Ruby changes and not js
stuff with yarn/webpacker etc.
On October 26, 2022, "dependabot[bot]" ***@***.***> wrote:
Fixed by #33 <#33> (I
created the PR for you)
β
Reply to this email directly, view it on GitHub
<#32 (comment)-
1292780350>, or unsubscribe
<https://github.com/notifications/unsubscribe-
auth/AQPMWL5JL3ZEZKYJEVVZSLDWFG623ANCNFSM6AAAAAAROQTZGU>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
Chris Oliver commented
That's a great idea. I'll add it to our backlog! π