Giters

exasol / virtual-schema-common-jdbc

Common module for JDBC-based access from Virtual Schemas

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Provide the `connectionDefinitionBuilder` in `AbstractQueryRewriter` through DI instead of by subclassing

chiaradiamarcelo opened this issue · comments

commented

The AbstractQueryRewriter uses internally a connectionDefinitionBuilder to build the connection definition string.

Every time we want/need a different implementation of the builder we are forced to subclass the QueryRewriter. We should provide the connectionDefinitionBuilder as a constructor parameter and let the client decide the right implementation