example42 / puppi

Puppet module to manage applications deployments and servers local management

Home Page:http://www.example42.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

auto_deploy does not work properly

k9ert opened this issue · comments

The order of the classes in run.pp is wrong:

the Puppi::run should run if everything else is done, so it should be:

Puppi::Run[$name] -> Class['puppi::is_installed']

Yes, you're right. This is most probably quite hard to fix. However it is very easy to fix for the puppi-consumer. Most probably, you will have a custom define where you might also put some other stuff like configuration-files or the like and it's probably quite easy to add

define myapp::appdeploy (

blablabla

) {

Manage the deployment-stuff

puppi::project::maven { $name:
# Blablaba
}
->
myapp::autodeploy { $name:
name => $name,
auto_deploy => $auto_deploy,
}
}

where myqpp::autodeploy would be defined like this:

define myapp::autodeploy(
$name,
$auto_deploy=false,
){
if ($auto_deploy == true) {
puppi::run { "$name": }
}
}

That way works perfectly for me. Probably the integrated autodeploy-feature should be deprecated because that feature simply does not work as expected.