ex-aws / ex_aws

A flexible, easy to use set of clients AWS APIs for Elixir

Home Page:https://hex.pm/packages/ex_aws

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

S3 objects with `?` in key cannot be queried

novaugust opened this issue · comments

  • Do not use the issues tracker for help or support (try Elixir Forum, Slack, IRC, etc.)
  • Questions about how to contribute are fine.

Environment

  • Elixir & Erlang versions (elixir --version): 1.14.2 / otp 25
  • ExAws version: aws 2.4.1 / s3 2.4.0
  • HTTP client version: hackney 1.18.1

Current behavior

could be similar to #546 , where special s3 path parsing breaks reaching an object

s3 objects with ? in the key are unreachable from ex_aws

It's true that S3's key naming strongly recommends against including ? in keys, but it allows and handles them all the same, and they're still accessible via its cli. Alas, in our case the mistake has already been made :)

Expected behavior

s3 objects with ? would ideally be reachable

Happy to look at a PR for this if there's a sane way to fix it (or even if there's a less-sane way that requires a config option to enable).