evmar / n2

n2 ("into"), a ninja compatible build system

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

`main` fails to build

tru opened this issue · comments

Tried main this morning and got this following error

error[E0499]: cannot borrow `*progress` as mutable more than once at a time
  --> src/run.rs:57:21
   |
30 |         progress,
   |         -------- first mutable borrow occurs here
...
52 |                 work = work::Work::new(
   |                 ---- first borrow might be used here, when `work` is dropped and runs the destructor for type `Work<'_>`
...
57 |                     progress,
   |                     ^^^^^^^^ second mutable borrow occurs here

I think I got around this error by upgrading my rust version (via rustup update).

Hrm, CI is passing. It might be a Rust version issue? I guess I can bump the minimum version to make it clearer for the next person?

I bisected versions:

1.59.0 bad
1.67.1 bad
1.68.2 bad
1.69.0 bad
1.70.0 good

So somehow 1.70.0 allows this when others don't? I looked through the changelog but didn't see anything that looked relevant.

Thanks for the fix, it builds correctly this morning!