Duplicate New Application Notifications
eeverett91 opened this issue · comments
-
Problem: Whats wrong?
-
The New Application discord notification was sent 5 times when someone applied to corporation.
-
Expected: What did you expect to happen?
-
Notification only sent once.
-
Logs / Screenshots / Proof: The more information you give the better!
-
Version Info: PHP Version, SeAT Version, Operating System etc.
SeAT API v4.9.0
SeAT Console v4.8.0
SeAT Eve API v4.18.1
SeAT Notifications v4.3.3
SeAT Services v4.2.1
SeAT Web v4.19.3
Perhaps its noteworthy that I have tokens for 5 characters with the personnel manager role in SeAT. Maybe it's sending one per toon/token that receives the notification?
Perhaps its noteworthy that I have tokens for 5 characters with the personnel manager role in SeAT. Maybe it's sending one per toon/token that receives the notification?
Yes that is correct. For each affiliated token we will directly forward the notification. I suggest reducing down to only one token.
I think I'll disable the notification. The tokens belong to toons from multiple players; recruiters + CEO + Directors. I would prefer not to remove their tokens.
Perhaps a feature request for the future could be to look for duplicate notifications and only send one?
I think I'll disable the notification. The tokens belong to toons from multiple players; recruiters + CEO + Directors. I would prefer not to remove their tokens.
You don't need to remove their tokens, just not include them in the notification groups affiliation list. Likewise if you have in the affiliation the corp, that matches all toons of the corp. So just place day the CEO in the affiliation.
Perhaps a feature request for the future could be to look for duplicate notifications and only send one?
It's something we should look into yes, but deduplicating is not always trivial.
I think I'll disable the notification. The tokens belong to toons from multiple players; recruiters + CEO + Directors. I would prefer not to remove their tokens.
You don't need to remove their tokens, just not include them in the notification groups affiliation list. Likewise if you have in the affiliation the corp, that matches all toons of the corp. So just place day the CEO in the affiliation.
Ah I'm following now, I'll do that thanks.
Perhaps a separate topic but any idea why the character name is coming up as unknown in the notification? The link to zKill works fine.
