mOnDuration value changes permanently, is it bug or feature?
mrNo0b opened this issue · comments
dF commented
I use this library with ESP32 Devkit v1
I noticed that if I call EasyBuzzer.singleBeep(720, 600);
for example, it will set beep duration to 600.
but then if I call EasyBuzzer.beep(420, 2);
this should beep twice, but because I called the singleBeep
before with duration of 600 now when I call beep
it will also have duration of 600.
I don't know if its a bug or by design but I don't think its the correct/expected behavior...
Steps to reproduce:
- run
beep
function first - it should play for the default duration (100) - run
singleBeep
function and set theduration
parameter - run
beep
function again - now it will have the duration that you set when calledsingleBeep
To quickly "fix" it I added this code:
mOnDuration = DEFAULT_ON_DURATION;
mOffDuration = DEFAULT_OFF_DURATION;
mPauseDuration = DEFAULT_PAUSE_DURATION;
inside the if
statement at
Line 123 in b0143dd
I don't think its the best fix but it worked...