[BUG] Expanded Room time-of-day tags do not update until post-character entry
jaborsh opened this issue · comments
Describe the bug
When entering an Expanded Room, characters will see an out-of-date description if time has reached a new tag but the room hasn't updated yet.
To Reproduce
Steps to reproduce the behavior:
- Use Expanded Rooms contrib
- Create a room with time of day tags.
- Visit room after time-of-day change.
- See error
Expected behavior
Rooms should update before a character enters so that the description is not incorrect.
Issue resolves if at_post_move logic is moved instead to at_object_receive, but I'm not sure that's an ideal solution.
I'm not familiar with the extended room code but this definitely sounds wrong. It should check if it needs to be updated when looked at, not based on object entry or departure, or things like changing time of day will not update correctly when spending time in a room.
It could be that it is, but the update is occurring after the description is retrieved instead of before?
I did some initial investigation of this, but didn't immedately see the issue. Will need more research.