char/industry_jobs seems to be returning status = failed prematurely.
flexd opened this issue · comments
As per http://wiki.eve-id.net/APIv2_Char_IndustryJobs_XML
Invention/completedStatus:
0 = failed
1 = delivered
2 = aborted
3 = GM aborted
4 = inflight unanchored
5 = destroyed
If it's not ready yet, completed = 0 and completedStatus is irrelevant/uninitialized/probably 0
If complete = 1 and status = 0, then it failed
Currently evelink returns failed on a job in-progress when it should be reporting something like 'in-progess' or whatever else what might be suitable.
The problem is here https://github.com/eve-val/evelink/blob/master/evelink/constants.py#L31 , and in the parser.
Do you agree? It should be a fairly easy fix.
Yeah, that looks like a bug.
5ef53e0 adds the missing "aborted" value; the parsing logic still needs fixing.
This is not working correctly. Completed and delivered jobs are now still showing as in-progress here.
I've sort of fixed it locally by making the changes I commented on the commit, but successful is still False for jobs I know are successful (just pulled a bunch of modules out from a job now)
The in-progress bug should be sorted now. I'm not sure what's up with completedSuccessfully.