Feature request: add station IDs to evelink.parsing.assets.parse_assets results
dinoboff opened this issue · comments
When an asset is in station, the location ID can be converted to a station ID:
http://wiki.eve-id.net/APIv2_Corp_AssetList_XML
evelink.parsing.assets.parse_assets could do the conversion and add a station key to every item result in station. It would be a dict holding the station id and a boolean indicating if the station is NPC (with all attributes in the static data dump) or conquerable (listed at eve/ConquerableStationList.xml.aspx).
It would be up to the user to query the correct data source to get the station name or owner.
@regner Would it be possible to introduce a cleaner way to do this kind of conversion (e.g. have it done as part of the asset APIs themselves)? I don't really like having magic number constants hanging around in 3rd party code.
I will attempt to see if there is something I can do, but don't have high
hopes.
Regner Blok-Andersen
http://highguard.net/
On Fri, Oct 31, 2014 at 6:39 PM, Amber Yust notifications@github.com
wrote:
@regner https://github.com/Regner Would it be possible to introduce a
cleaner way to do this kind of conversion (e.g. have it done as part of the
asset APIs themselves)?—
Reply to this email directly or view it on GitHub
#127 (comment).
No worries. Seems like more of a "nice to have" than anything critical.
I still don't really like the idea of having magic number conversion going on in the default return objects. Perhaps this might be a candidate for a utility function included in evelink/thirdparty or some such? Then people who want to do that conversion can do it easily, but if it ever breaks we're not on the hook for providing bad data.