evashort / chords

Text-based chord progression editor

Home Page:http://evanshort.name/chords/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Classes for DOM elements

suhr opened this issue · comments

I wanted to improve the UI with a userstyle, but DOM elements lack classes.

Interesting. Adding classes is easy. Can you give me some guidance on which elements need classes, and which groups of elements should have the same class?

which elements need classes

More is better.

which groups of elements should have the same class

Well, it's useful to have different classes for different things and same classes for same things.

Sorry, but it's not at all obvious to me how to assign classes. If you can list some specific types of things you want to style, I'll be happy to add classes for them.

At least everything with grid-area. Though their elements also need classes.

Actually, you already have some names in your code (viewBpm, viewScale, etc...). Why not make corresponding classes for these names?

Sure, I'll start with assigning an id to the parent element of each grid area. I could also add classes for checkbox, range input, chord button, chord button blue border, and chord button dashed blue border.

Ok, these changes should be live now (may have to hard refresh).