Warning when completing `kubectl get pods --all-`
pklaus opened this issue · comments
Nice job on this completions file! 👍
I get a warning when I enter kubectl get pods --all- and then hit Tab. But after all it finally correctly expands to --all-namespaces, so when I hit Enter subsequently, I get the expected output, but the warning in between is a bit irritating:
me@host /# kubectl get pods --all-No resources found in default namespace.
string match: Unknown option “--all-”
/usr/share/fish/completions/kubectl.fish (line 1):
in command substitution
called on line 242 of file /usr/share/fish/completions/kubectl.fish
in function '__fish_kubectl_has_partial_resource_match'
in command substitution
(Type 'help string' for related documentation)
string match: Unknown option “--all-”
/usr/share/fish/completions/kubectl.fish (line 1):
string match -r "(.*)/" $last
^
in command substitution
called on line 255 of file /usr/share/fish/completions/kubectl.fish
in function '__fish_kubectl_print_matching_resources'
in command substitution
(Type 'help string' for related documentation)
namespaces
NAMESPACE NAME READY STATUS RESTARTS AGE
kube-system calico-kube-controllers-76d4774d89-rlzdl 1/1 Running 0 84m
kube-system calico-node-58t6n 1/1 Running 0 84m
kube-system coredns-66bff467f8-4crfp 1/1 Running 0 10h
kube-system coredns-66bff467f8-pn9j5 1/1 Running 0 10h
kube-system etcd-k8s-master 1/1 Running 1 10h
kube-system kube-apiserver-k8s-master 1/1 Running 1 10h
kube-system kube-controller-manager-k8s-master 1/1 Running 1 10h
kube-system kube-proxy-4qszf 1/1 Running 0 10h
kube-system kube-scheduler-k8s-master 1/1 Running 1 10h
@pklaus Thanks! I really appreciate that! This should be fixed in master. Thanks for the reporting the issue and please let me know if anything else is not working properly. :]
Works like a charm now. Thanks for the fix! I'll report back if I find something else. For now, it's working great.