How the new react context api affects react-gettext

Question

How the new react context api affects react-gettext

shirazz opened this issue 6 years ago · comments

I think we have to update the library in such a way that it will work with both versions of react. Means 16.3.0 as well as the pervious ones. Any suggestions on where we should start.

Eugene Manuilov · Answer 1 · Sat Mar 10 2018 16:45:34 GMT+0800 (China Standard Time)

Hey @shirazz,

yes, it is a good idea. I haven't looked at it yet, thus can't say anything specific yet. I'll try to find a time to look at it on next week. If you have already checked it and have ideas, then your pull request will be more than a welcome!

Jimi Pajala · Answer 2 · Thu Apr 05 2018 14:14:06 GMT+0800 (China Standard Time)

Any updates according to new Context API and migrating to using that?

I might try and look in to this on upcoming weekend.

Shiraz Samad · Answer 3 · Mon Apr 16 2018 16:07:32 GMT+0800 (China Standard Time)

@bumpah did you get a chance to have a look at this. I can also help you as i think it is a nice thing to have.

Jimi Pajala · Answer 4 · Tue Apr 17 2018 00:41:58 GMT+0800 (China Standard Time)

@shirazz still haven't had opportunity to look into this. i'll try asap to reserve some time to this also. Help would be more than great!

Jimi Pajala · Answer 5 · Wed Apr 18 2018 00:49:59 GMT+0800 (China Standard Time)

@shirazz I'll take some time this evening to look into what would needed to be done.

Jimi Pajala · Answer 6 · Fri Apr 20 2018 14:37:35 GMT+0800 (China Standard Time)

I've made some research and plans how to migrate towards using new context API and will try complete this during upcoming weekend.

Shiraz Samad · Answer 7 · Fri Apr 20 2018 15:26:51 GMT+0800 (China Standard Time)

Would you mind sharing your findings Jimi. FRONTEND DEVELOPER Shiraz Samad shirazwaits@gmail.com shirazsamad Skype Linkedin : Shirazsamad Twitter : Shirazz Facebok : Shiraz.samad Mobile : 971-569240260

…

On Fri, Apr 20, 2018 at 10:37 AM, Jimi Pajala ***@***.***> wrote: I've made some research and plans how to migrate towards using new context API and will try complete this during upcoming weekend. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#18 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABcwVHo8jxhpGyREY32Dytmz-CikbEApks5tqYIwgaJpZM4Si8Fc> .

Eugene Manuilov · Answer 8 · Wed Jul 17 2019 00:52:54 GMT+0800 (China Standard Time)

Hey everyone! A new version (1.0.0) has been published that uses new Context API.

I am closing this thread for now. Feel free to open a new issue if you have troubles with the new version.