Always creates 2 bars (Windows msys2, CentOS 7.4)

[Jory Schossau]

I recreated the demo, but I always get 2 bars, perhaps related to the extra printing of a '%' symbol?

[================================================.....................] 69.00%%
[=====================================================================>] 100.00%

nim v 0.19.4 installed progress via nimble

[Euan Torano]

Interesting, I’ll have to test this out and see if I can recreate the problem. Thanks for the report!

…

On 28 Feb 2019, at 01:57, Jory Schossau ***@***.***> wrote: I recreated the demo, but I always get 2 bars, perhaps related to the extra printing of a '%' symbol? [================================================.....................] 69.00%% [=====================================================================>] 100.00% nim v 0.19.4 installed progress via nimble — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[Jory Schossau]

Some more information.
On windows:
run though cmd, all operates correctly (single bar, fits window width)
run through msys2 it fails to find the terminal width correctly and produces 2 bars.
Usually, running a failing CLI utility using winpty (wintpy ./test.exe) fixes these kinds of issues, but not here.

[Jory Schossau]

I get the same symptom of 2 bars on native CentOS 7.4 if I try setting the total to 1000 then calling increment() 1000 times, even with a slow sleep (using the same demo code):

[=====...............................................................] 6.80%%
[====================================================================>] 100.00%

I've narrowed it down in CentOS to being contingent on only if the terminal width is less than total+11 where total is the quantity given in the constructor newProgressBar(total=...)

[Euan Torano]

Interesting! Thanks for the detailed information. I’ve only tested on Windows (PowerShell + CMD) and Mac personally, but I’ll have a try with some other platforms and see if I can track down the issue.

…

On 28 Feb 2019, at 13:54, Jory Schossau ***@***.***> wrote: I get the same symptom of 2 bars on native CentOS 7.4 if I try setting the total to 1000 then calling increment() 1000 times: [=====...............................................................] 6.80%% [====================================================================>] 100.00% — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAttcU_zA0n3aEEkvjutKSpnIjXzzAHHks5vR9-WgaJpZM4bV1wL>.

[Euan Torano]

Yeah, I can re-produce this on my Mac too, it's pretty odd what it does here though:

It seems that isComplete() is returning true prematurely, I need to work out why.