Giters

etro-js / etro

Typescript video-editing framework for the browser

Home Page:https://etrojs.dev

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Release commit log link broken

clabe45 opened this issue · comments

commented

Etro uses ShipJS to deploy new versions. Along with publishing versions to NPM and doing some other release chores, by default, Ship.js creates GitHub releases, extracting the release notes from CHANGELOG.md. Since the header link's destination is declared at the bottom of CHANGELOG.md, a ShipJS bug prevents the link's destination from being included in the GitHub release notes, so the link does not render properly (example). I tried to fix this in ccd6c55, but the issue is still happening. I believe it's because releases needs to be an object, not an array (ShipJS docs).