Custom duration for `play()`

Question

Custom duration for `play()`

clabe45 opened this issue 2 years ago · comments

Lean Junio · Answer 1 · Thu Apr 20 2023 03:03:42 GMT+0800 (China Standard Time)

Would it be possible to get more context on this? I'd love to tackle it.

Would duration just be a number that represents seconds? And is the idea just that if play() is passed a duration, the move would just play for that many seconds?

Caleb Sacks · Answer 2 · Fri Apr 21 2023 00:23:43 GMT+0800 (China Standard Time)

Hey, yes to both. It would be a number in seconds, and it would stop after that many seconds passes. The record function already supports a duration, you can use that for reference.

Lean Junio · Answer 3 · Fri Apr 21 2023 01:00:10 GMT+0800 (China Standard Time)

@clabe45 for this to work, do we just need to update this._endTime to be this.currentTime + duration?

Caleb Sacks · Answer 4 · Fri Apr 21 2023 01:02:04 GMT+0800 (China Standard Time)

Yeah, move the assignment from stream to play (stream calls play)

Lean Junio · Answer 5 · Fri Apr 21 2023 01:10:03 GMT+0800 (China Standard Time)

I have #208 for this