etoile / CoreObject

Distributed version control + object persistence framework

Home Page:http://coreobject.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Use const with local variables consistently

qmathe opened this issue · comments

Currently we sometimes use const as a local variable qualifier when the type is a number like BOOL, Int, etc.

We should do a global search/replace and add const where it makes sense, or remove it from local variables in the code base.

Personally I'm fine with both approaches.

IMO it makes sense in low level code. If there is any re-assigning / modifying of variables other than loop counters in the method, it's probably a good idea to use const.

ok. So I keep this issue opened until we take the time to review the code and apply const everywhere it makes sense.

Everything looks ok now, so I'm closing this issue.