etn-ccis / blui-react-showcase-demo

A sample project for testing new components, themes, etc.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Fix performance issue after mui v5 migration and pass correct type to style objects

bkarambe opened this issue · comments

Describe the bug

There is a performance issue in react-showcase-demo while navigating from one page to another. This got introduced during mui v5 migration.
Styled objects passed to sx props should have correct type and should throw error, when incorrect styles are passed

What is the expected behavior?

All pages should render smoothly without a lag.
An error should occur, when incorrect styles are being passed to style objects

What are the steps to reproduce?

  1. yarn start
  2. Click on the various drawer nav items, change direction to navigate to different pages/directions

Screenshots or links to minimum reproduction example

Screen.Recording.2022-07-08.at.5.07.48.PM.mov

Environment

Anything else to add?

Use this issue to remove CacheProvider.

BLUI-3356