Save VersionId in model

[Mees]

I was wondering if there is a more appropriate way to save the VersionId in a model when updating it. The way I currently came up with is:

my_model = MyModel()
# write query and S3 PUT request
my_model.my_file_field.save("someName.html", file)

# S3 request
version_id = S3Storage().meta(my_model.my_file_field.name)['VersionId']

# write query
my_model.latest_version_id = version_id
my_model.save()

This requires 2 request and 2 writes, which seems a bit cumbersome, being able to access the VersionId when the file is updated would enable it do everything in one go (i.e. 1 write and 1 request). Looked at the source code but couldn't find a way to access the meta data on the response, only by doing an additional request with .meta() or am I overlooking something?

[Dave Hall]

The trouble with a file storage abstraction is that you have the lowest common denominator between all platforms. If you want more control, I'd use the S3 boto library directly. If you're careful, you can use it in parallel with django-s3-storage. You just need to save the filename in the model's file field when you save the file to S3. Once saved correctly, you can use django-s3-storage for subsequent access, and for compatibility with the rest of Django.

…

On Thu, 12 Sep 2019 at 23:45, Mees ***@***.***> wrote: I was wondering if there is a more appropriate way to save the VersionId in a model when updating it. The way I currently came up with is: my_model = MyModel()# write query and S3 PUT request my_model.my_file_field.save("someName.html", file) # S3 request version_id = S3Storage().meta(my_model.)['VersionId'] # write query my_model.latest_version_id = version_id This requires 2 request and 2 writes, which seems a bit cumbersome, being able to access the VersionId when the file is updated would enable it do everything in one go (i.e. 1 write and 1 request). Looked at the source code but couldn't find a way to access the meta data on the response, only by doing an additional request with .meta() or am I overlooking something? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#98?email_source=notifications&email_token=AABEKCB2FNCMZ3KPAZ7QYBTQJLA7BA5CNFSM4IWKLNG2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HLDRJJA>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABEKCA34MOYQW5ZVNJFHA3QJLA7BANCNFSM4IWKLNGQ> .

[Mees]

Thanks for the fast response. The problem is that I want certain versions to be bookmarked, e.g. I want versions saved by an administrator to be bookmarked while versions saved by normal users not. This way I can easily serve the user with the last version the administrator approved, while users can upload new versions for the administrator to be approved.

I was using the boto3 library directly but this library seemed to take away a lot of boiler plate code, and make the codebase more maintainable. But I guess I've to write some magic myself then ;).

Just to clarify my scenario: The general idea is that the user uploads some Html, we run some check on it. Then convert the string into a file with ContentFile (from django.core.files.base import ContentFile) and save it under the original name for the FileField. Each subsequent upload of html goes to the same process, when an administrator uploads the Html we catch the VerionId and put it in the model as last_approved_id. This way we can serve the users the last approved html, while we can serve the admins the last uploaded Html by doing a request without VerionId. We're trying to make a kind of Wikipedia with approval.

Anyway, thanks for the response, I'll close the issue.