Question about ManifestStaticS3Storage
greenpasta opened this issue · comments
I've configured as follows:
AWS_ACCESS_KEY_ID = 'xxxx'
AWS_SECRET_ACCESS_KEY = 'yyyy'
AWS_S3_BUCKET_NAME_STATIC = 'myapp-static'
AWS_S3_MAX_AGE_SECONDS = '315360000'
STATICFILES_STORAGE = 'django_s3_storage.storage.ManifestStaticS3Storage'
The huge MAX_AGE is great so my visitors never have to reload static assets, if any of them change they'll have a new name. However... this also puts that MAX_AGE on staticfiles.json, so I think the clients also cache that basically forever and won't realize when other static assets have changed.
Is this a valid concern? Am I doing this right?
staticfiles.json isn't ever read by clients. It's there to be read by the
Django storage backend.
So I think you're good.
…On Thu, 14 Nov 2019 at 15:51, greenpasta ***@***.***> wrote:
I've configured as follows:
AWS_ACCESS_KEY_ID = 'xxxx' AWS_SECRET_ACCESS_KEY = 'yyyy'
AWS_S3_BUCKET_NAME_STATIC = 'myapp-static' AWS_S3_MAX_AGE_SECONDS =
'315360000' STATICFILES_STORAGE =
'django_s3_storage.storage.ManifestStaticS3Storage'
The huge MAX_AGE is great so my visitors never have to reload static
assets, if any of them change they'll have a new name. However... this also
puts that MAX_AGE on staticfiles.json, so I think the clients also cache
that basically forever and won't realize when other static assets have
changed.
Is this a valid concern? Am I doing this right?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#103?email_source=notifications&email_token=AABEKCGNDU2H3QVBSOXQUGLQTVXWHA5CNFSM4JNNWXH2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HZLQV5A>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABEKCCCCJAEVTKCOZGHML3QTVXWHANCNFSM4JNNWXHQ>
.
Yes, thanks! I had a different misconfiguration that led me to believe this was happening. Nothing to see here.