Refactor: Use ES6 classes and extends keyword instead of util.inherits

Question

Refactor: Use ES6 classes and extends keyword instead of util.inherits

holgerd77 opened this issue 7 years ago · comments

The current way the different Trie class objects are constructed is not very readable, furthermore the use of util.inherits in Node is discouraged.

This should be reworked to use ES6 classes, constructors together with the extends keyword to inherit properties and methods.

Alexander Tseung · Answer 1 · Thu Sep 27 2018 01:07:40 GMT+0800 (China Standard Time)

I can take a look at this

Holger Drewes · Answer 2 · Thu Sep 27 2018 18:09:01 GMT+0800 (China Standard Time)

Hi Alex, just discovered that people are working on a pretty interesting and advanced fork of this library. Have started a discussion on that here: #54.

Maybe wait with this, would like to see where we are going there. If you want, you can also have a look at the fork from RainBlock, I think it should be possible to take many of the changes done there back into the library here.

Alexander Tseung · Answer 3 · Fri Sep 28 2018 00:33:10 GMT+0800 (China Standard Time)

Ah ok. Thanks for the heads up @holgerd77

Sina M · Answer 4 · Thu Jan 10 2019 16:17:45 GMT+0800 (China Standard Time)

Thanks to @alextsg, most of the library has been ported to ES6 classes in #57 and #61. What remains now is trieNode. I was also wondering as to the purpose of secureInterface and checkpointInterface, why are they not implemented in SecureTrie and CheckpointTrie respectively?

Sina M · Answer 5 · Tue Jan 22 2019 15:52:55 GMT+0800 (China Standard Time)

The whole code base has been now ported to ES6 classes, see #57, #61, #71 and #73.