ethereum / tests

Common tests for all Ethereum implementations

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Split EIPTests into a different branch so not to confuse

winsvega opened this issue · comments

tests in EIPTests are experimental and often not refer to updated specs. this leads to confusion.
I prefer to keep develop branch updated to the latest specs of all accepted EIPs.

I Suggest to move EIPTests folder to a separate test branch. and merge experimental tests there

@holiman @marioevz

Totally see the problem. I wonder if these are a bit (too) hidden though if in a separate branch? 🤔 With some risk that people are not using? Maybe there are also other options to explore? Not have the one brilliant idea though yet.

Another option was to make it be in a separate folder like ExperimentalTests next to GeneralStateTests and BlockchainTests folder

Another option was to make it be in a separate folder like ExperimentalTests next to GeneralStateTests and BlockchainTests folder

I vote for this one

Here is the suggestion:

src/EIPTestsFiller   ==>   EIPTests (state test format)
src/EIPTestsFiller   ==>   BlockchainTests/EIPTests/GeneralStateTests (blockchain test format)
src/BlockchainTestsFiller/EIPTests  ==>  BlockchainTests/EIPtests

@jangko @holgerd77

this way EIPTests remain separate from normal tests. explicitly and never are in subfolder of normal tests.

here all EIP tests are living in a separate EIPTests folder. both bc and state versions
#1192