Lint failing
pettinarip opened this issue · comments
Describe the bug
Our current lint process is failing because we don't have esling-config-prettier installed.
To reproduce
Run yarn lint.
Expected behavior
We need to install esling-config-prettier + fix all the current error & warnings.
Screenshots
No response
Desktop (please complete the following information)
No response
Smartphone (please complete the following information)
No response
Additional context
No response
Would you like to work on this issue?
- Yes
- No
@pettinarip if you'd like, I can take this as well!
@pettinarip in fixing errors and warnings: how would you prefer handling escaped characters?
<p>
When's it shipping?
</p>or
<p>
{`When's it shipping?`}
</p>Probably want this situation clarified in the docs as well.
@pettinarip in fixing errors and warnings: how would you prefer handling escaped characters?
<p> When's it shipping? </p>or
<p> {`When's it shipping?`} </p>Probably want this situation clarified in the docs as well.
@nhsz @wackerow @corwintines ^ what do you guys think?
In other EF projects, we have been using the ' way. So, probably it is better to keep them consistent.
=====
However, I must say that I find this rule annoying but understand the benefits haha it is what it is 🤷🏼
@pettinarip in fixing errors and warnings: how would you prefer handling escaped characters?
<p> When's it shipping? </p>or
<p> {`When's it shipping?`} </p>Probably want this situation clarified in the docs as well.
@nhsz @wackerow @corwintines ^ what do you guys think?
In other EF projects, we have been using the
'way. So, probably it is better to keep them consistent.=====
However, I must say that I find this rule annoying but understand the benefits haha it is what it is 🤷🏼
In favor of keeping '
I prefer
{`When's it shipping?`}
But, for consistency sake, I agree and can keep '