Last Call changes must be separate from the PR to move to Final

Question

Last Call changes must be separate from the PR to move to Final

xinbenlv opened this issue a year ago · comments

Proposed Change

Shall we consider impose a rule that for when a last-call EIP changes a lot, they shall not go to Final in that same commit and, maybe, revert to Review to give people more time for reviewing the updated version.

This issue was inspired in #6128

Gavin John · Answer 1 · Wed Dec 14 2022 05:33:32 GMT+0800 (China Standard Time)

I strongly agree with this. Minor changes can forgo the reset of the last call timer. Major changes should reset it.

github-actions · Answer 2 · Mon Apr 03 2023 08:17:40 GMT+0800 (China Standard Time)

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

Gavin John · Answer 3 · Mon Apr 03 2023 21:31:04 GMT+0800 (China Standard Time)

@xinbenlv are you making a PR, or should I?

xinbenlv · Answer 4 · Tue Apr 04 2023 02:05:14 GMT+0800 (China Standard Time)

I could add it to EIP-1 as a rule (PR #6824). It would be nice if you could make a PR in the eipw or proper bot lint.

Gavin John · Answer 5 · Tue Apr 18 2023 02:00:53 GMT+0800 (China Standard Time)

Fixed in #6824.