Editorial Issues with ERC3475
xinbenlv opened this issue · comments
Pull Request
https://github.com/ethereum/EIPs/pull/5385/files
What happened?
As I am developing interfaces from various ERCS, I discovered a few editorial issues in the ERC3475
- Burn was a given as an example but no event was defined
- burnBond in comment doesn't exist in any definition in this file
- transferAllowanceFrom was declared with "virtual override" which isn't an valid solidity interface
- Usages of
emit
implementation code andevent
with interface renders non-compilable code in any place. - In consistency and mixure usage of
//
vs/**/
.
A discussion for editorial policy / procedure: shall we consider impose a rule that for when a last-call EIP changes a lot, they shall not go to Final in that same commit and, maybe, revert to Review
to give people more time for reviewing the updated version. I will file a separate issue for procedure proposal
Notify: @dhruvmalik007 @yuliu-debond
I think policy is generally to restart the last call timer if there are substantial changes to an EIP, but it looks like that didn't happen here.
Thanks, @xinbenlv for the notification, in fact we had the PR in order to resolve some of the changes in the given PR.
so we will do a final review of the inconsistencies that you have mentioned above and then insure from the next EIP proposal coming to final, there will be time for reviewing the updated version.