ethereum / EIPs

The Ethereum Improvement Proposal repository

Home Page:https://eips.ethereum.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Dynamic Required Approvals

Pandapip1 opened this issue · comments

My recommendation was to have changes to non-EIPs require a decreasing number of approvals based on how long they have been open. Something like:

1 week: 5 approvals
2 weeks: 4 approvals
4 weeks: 3 approvals
8 weeks: 2 approvals
16 weeks: 1 approval
and a single rejection would prevent auto-merging.

The idea here is that if there is consensus among all editors then things would go through quickly and smoothly. If, however, there aren't enough actively engaging editors then system doesn't permanently freeze/halt, it just slows down.

Originally posted by @MicahZoltu in #5640 (comment)

My suggestion is a little bit more general. If all editors approve, then a change gets instantly merged. If an editor approves, it starts a one-month countdown before it is automatically merged. If subsequent editors approve, it halves that countdown. A "request changes" review pauses this countdown.

Sounds reasonable. Maybe a function of 5- log(2, week)?

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

Dismissing stale bot.

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

Dismissing stale bot.

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

Dismissing stale bot.

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

Dismissing stale bot.

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

Dismissing stale bot

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

Dismissing stale bot

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

I think the consensus was that this is a good idea if it can be implemented.