ethanent / phin

Node HTTP client

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Follow redirects

julianxhokaxhiu opened this issue · comments

Hi,

I'm using this library at the moment which is very cool as it is small, lightweight and it does its job pretty well. Although I currently miss one small feature that is the ability to follow redirects if a specific URL replies back with any Location header inside of it.

Would you mind implementing it in your own library?

Thank you in advance,
Julian

commented

Thanks for the feature request. This would definitely be possible to do with a wrapper client, but I do see why it could be useful to have built-in! I'll leave the issue open as a potential feature addition!

Thank you! At the moment this is what I did, I wrapper your library within a recursive function. Although I would like, for the sake of implementation ( as I am using this library inside unit tests ) to keep the code simpler and cleaner.

The addition would definitely be a great one for whoever wants to use it. At the moment the only one which supports this of the box is request.

commented

Thanks for the suggestion! This feature has been implemented in minor release 3.1.0. (71b308f)

Adding an option to specify a maximum number of redirects to follow is on the agenda.