eth-cscs / stackinator

Home Page:https://eth-cscs.github.io/stackinator/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

recipe repo patch files are needed, but useless

biddisco opened this issue · comments

When you create a custom repo for a package with stackinator (and presumably with any other use of spack with custom repos) - you have to copy all the patch files for that repo into your edited/cloned/local repo copy - even when those patch files are specific to versions that you are not building and never plan to. for example, for my egl paraview build I need to override 4 packages, and I get this

a100/repo
a100/repo/packages
a100/repo/packages/opengl
a100/repo/packages/opengl/package.py
a100/repo/packages/egl
a100/repo/packages/egl/package.py
a100/repo/packages/glew
a100/repo/packages/glew/package.py
a100/repo/packages/glew/remove-pkgconfig-glu-dep.patch
a100/repo/packages/paraview
a100/repo/packages/paraview/vtk-adios2-module-no-kit.patch
a100/repo/packages/paraview/gcc-compiler-pv501.patch
a100/repo/packages/paraview/catalyst-etc_oneapi_fix.patch
a100/repo/packages/paraview/h5part-parallel.patch
a100/repo/packages/paraview/FindFreetype.cmake.patch
a100/repo/packages/paraview/package.py
a100/repo/packages/paraview/vtk-xdmf2-hdf51.13.1.patch
a100/repo/packages/paraview/xlc-compilation-pv590.patch
a100/repo/packages/paraview/adios2-remove-deprecated-functions.patch
a100/repo/packages/paraview/ui_pqExportStateWizard.patch
a100/repo/packages/paraview/vtkm-catalyst-pv551.patch
a100/repo/packages/paraview/stl-reader-pv440.patch
a100/repo/packages/paraview/paraview-gcc11-limits.patch
a100/repo/packages/paraview/exodusII-netcdf4.9.0.patch
a100/repo/packages/paraview/vtkm-findmpi-downstream.patch
a100/repo/packages/paraview/vtk-xdmf2-hdf51.13.2.patch

since there are patches in several of the packages (glew/paraview).

Would it be feasible/sensible, to not require the user to make copies of all these patch files in the recipes repo, and instead have stackinator copy them from the config.yaml spack: repo: location into the user configured repo during the stackinator config step? My suspicion is that this would be a good idea and as long as any patch files the user adds locally are not overwritten, I can't see a downside.