Giters

esprfid / esp-rfid

ESP8266 RFID (RC522, PN532, Wiegand, RDM6300) Access Control system featuring WebSocket, JSON, NTP Client, Javascript, SPIFFS

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Code mixes tabs and spaces

mtfurlan opened this issue · comments

commented

I noticed that there is a mix of tabs and spaces.
I'm happy to make a PR to clean that up, but which way should it go?
I would personally prefer spaces, but I'll make it consistent either way.

commented

Hello,

Spaces are nice 😊 .

commented

What about

if (stuff)
{
    ...
}

vs

if (stuff) {
    ...
}

?
I thought there was only the former but I just found some of the latter.

Would you be interested in having an uncrustify config?

I dunno what the best way to keep the codebase in line with a config would be though.
At $work I don't allow a PR to merge if it doesn't pass an automated run of the linter, but that seems like it might be overly complicated here.

commented

As I mentioned here: #524 (comment) I don't mind which way you prefer, so long as it's automatically set up by VS Code and ideally in the CI, so that we cannot break it again :) Thanks!